[patch] Fix BZ15121 -- x/a broken for addresses in shared libraries

[Pedro Alves]

On 09/06/2015 09:03 PM, Paul Pluzhnikov wrote:

> index 91bf49e..0624b90 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -2927,7 +2927,13 @@ unpack_pointer (struct type *type, const gdb_byte *valaddr)
>  {
>    /* Assume a CORE_ADDR can fit in a LONGEST (for now).  Not sure
>       whether we want this to be true eventually.  */
> -  return unpack_long (type, valaddr);
> +  LONGEST ret = unpack_long (type, valaddr);
> +  int len = TYPE_LENGTH (type);
> +  if (sizeof (CORE_ADDR) > len && ret < 0) {
> +    /* Don't sign-extend 32-bit pointer.  BZ 15121.  */
> +    return ret & ((1UL << (8 * len)) - 1);
> +  }
> +  return ret;
>  }

Do we need to keep sign-extending on MIPS?  Adding Maciej.

Thanks,
Pedro Alves