[PATCH] Type-safe wrapper for enum flags

Pedro Alves palves@redhat.com
Sat Oct 31 20:28:00 GMT 2015


On 10/30/2015 03:41 PM, Simon Marchi wrote:
> On 15-10-30 10:52 AM, Pedro Alves wrote:
>> Looks like c-lang.h should include common/enum_flags.h.
> 
> Good point.  Include What You Use.

It should be included in the .h file, IMO.  Otherwise, if
anything includes c-lang.h that doesn't happen to pull in
enum_flags.h already, it'll break.

> 
>> Otherwise LGTM.
>>
>> I'd like to collect at least one Ack on the enum flags patch
>> before pushing it.
> 
> Here is the patch with the include.  When it's time to push your patch,
> can you make this one follow?

Sure thing.  I'll put it in the C++ branch meanwhile.

I'll take care of the moving the include.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list