[PATCH] Remove explicit leading space in query strings

Joel Brobecker brobecker@adacore.com
Fri Oct 30 05:10:00 GMT 2015


On Thu, Oct 29, 2015 at 08:43:12AM -0400, Patrick Palka wrote:
> Instead of requiring each caller of the query() family of functions to
> add a leading space to the inputted query string (so that there is a
> separator between the query string and the "(y or n)" suffix that is
> appended to it), this patch instead makes the callee always add this
> leading space before appending the "(y or n)" suffix, so that each caller
> won't have to.  (Some existing query strings passed to the query()
> family of function did not yet have a leading space.  This patch
> also implicitly fixes such occurrences.)
> 
> I discovered the list of queries to change in this patch by grepping for
> the string "? \")".

The only comment I have is "leading" -> "trailing" ;-)
Let's hope you see that before you push!

-- 
Joel



More information about the Gdb-patches mailing list