[PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports
Pedro Alves
palves@redhat.com
Mon Oct 19 15:42:00 GMT 2015
On 10/11/2015 01:01 PM, Iain Buclaw wrote:
> Whilst looking at part one, a moment of insight came to me and I
> realized this code is completely nonsensical.
>
> For a start, when importing modules, you don't gain access to all
> parent packages of the given module.
>
> To add some confusion, even the comment was wrong. It doesn't even
> cater for the example given (it's d_lookup_symbol_module that walks up
> each block scope).
>
> I feel embarrassed it didn't come to me before. :-)
The usual penance is writing test cases. :-)
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list