[PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
Metzger, Markus T
markus.t.metzger@intel.com
Mon Oct 19 09:42:00 GMT 2015
> -----Original Message-----
> From: Eli Zaretskii [mailto:eliz@gnu.org]
> Sent: Monday, October 19, 2015 11:37 AM
> To: Metzger, Markus T
> Cc: dje@google.com; gdb-patches@sourceware.org; palves@redhat.com
> Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix
> documentation
Thanks for the quick response.
> > +It can also print mixed source+disassembly by specifying the @code{/m}
> > +or @code{/s} modifier and print the raw instructions in hex as well as
> > +in symbolic form by specifying the @code{/r} modifier.
>
> "By specifying" makes it sound like you are talking about the command,
> because of the "It" that starts the sentence. Suggest to reword:
>
> It can also print mixed source+disassembly if you specify the @code{/m}
> or @code{/s} modifier, and print the raw instructions in hex as well as
> in symbolic form by specifying the @code{/r} modifier.
>
> Note that I also added a missing comma before "and".
Fixed. Thanks.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
More information about the Gdb-patches
mailing list