[PATCH v2 2/3] Display names of remote threads

Yao Qi qiyaoltc@gmail.com
Fri Nov 27 14:37:00 GMT 2015


Simon Marchi <simon.marchi@ericsson.com> writes:

> +  attr = xml_find_attribute (attributes, "name");
> +  item.name = attr != NULL ? xstrdup (attr->value) : NULL;
> +

This breaks the C++ build,

/home/yao/SourceCode/gnu/gdb/git/gdb/remote.c: In function ‘void start_thread(gdb_xml_parser*, const gdb_xml_element*, void*, VEC_gdb_xml_value_s*)’:
/home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:2975:50: error: invalid conversion from ‘void*’ to ‘const char*’ [-fpermissive]
   item.name = attr != NULL ? xstrdup (attr->value) : NULL;
                                                  ^
In file included from /home/yao/SourceCode/gnu/gdb/git/gdb/common/common-defs.h:64:0,
                 from /home/yao/SourceCode/gnu/gdb/git/gdb/defs.h:28,
                 from /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:22:
/home/yao/SourceCode/gnu/gdb/git/gdb/../include/libiberty.h:323:14: note: initializing argument 1 of ‘char* xstrdup(const char*)’
 extern char *xstrdup (const char *) ATTRIBUTE_MALLOC ATTRIBUTE_RETURNS_NONNULL;

and I think you've already received the mail from buildbot.
http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64/builds/1413

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list