[PATCH v2 1/3] Constify thread name return path
Simon Marchi
simon.marchi@ericsson.com
Thu Nov 26 15:46:00 GMT 2015
On 15-11-26 06:21 AM, Pedro Alves wrote:
> On 11/25/2015 09:48 PM, Simon Marchi wrote:
>> Since this code path returns a string owned by the target (we don't know how
>> it's allocated, could be a static read-only string), it's safer if we return
>> a constant string. If, for some reasons, the caller wishes to modify the
>> string, it should make itself a copy.
>>
>> gdb/ChangeLog:
>>
>> * linux-nat.c (linux_nat_thread_name): Constify return value.
>> * target.h (struct target_ops) <to_thread_name>: Likewise.
>> (target_thread_name): Likewise.
>> * target.c (target_thread_name): Likewise.
>> * target-delegates.c (debug_thread_name): Regenerate.
>> * python/py-infthread.c (thpy_get_name): Constify local variables.
>> * thread.c (print_thread_info): Likewise.
>> (thread_find_command): Likewise.
>
> OK.
>
> Thanks,
> Pedro Alves
>
Thanks, pushed.
More information about the Gdb-patches
mailing list