[PATCH] Fix '-data-read-memory-bytes' typo/assertion

Pedro Alves palves@redhat.com
Thu Nov 19 23:06:00 GMT 2015


On 11/19/2015 12:53 AM, Don Breazeal wrote:

> gdb/
> 2015-11-18  Don Breazeal  <donb@codesourcery.com>
> 
> 	* gdb/target.c (read_memory_robust): Call
> 	read_whatever_is_readable with arguments in the correct order.
> 

Please drop the "gdb/" in the file name.

LGTM too.  Obvious even.  It'd be nice to have a testcase
for this though.  Seems like the simplest would be to just try
e.g., "-data-read-memory-bytes 8 1" and make sure that fails
with "Unable to read memory".  We'd just need to skip the
test if [is_address_zero_readable].

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list