[PATCH 2/2] Fix gdb.threads/multiple-step-overs.exp fails on arm
Yao Qi
qiyaoltc@gmail.com
Tue Nov 17 15:41:00 GMT 2015
Pedro Alves <palves@redhat.com> writes:
> The reason we resume a single thread and leave others stopped when doing a
> normal step over where we temporarily remove the breakpoint, single-step,
> reinsert the breakpoint, is that if we let other threads run in the period
> while the breakpoint is removed, then these other threads could miss
> the breakpoint. Since with displaced stepping, we don't ever remove the
> breakpoint, it should be fine to let other threads run. However,
> there's another
> reason that we should not let other threads run: that is the case where some of
> those threads are also stopped for a breakpoint that itself needs to be
> stepped over. If we just let those threads run, then they immediately re-trap
> their breakpoint again.
>
OK, copy them into the commit log.
>>
>> Patch below is regression tested on x86_64-linux and arm-linux.
>>
>
> LGTM.
Patch is pushed in.
--
Yao (齐尧)
More information about the Gdb-patches
mailing list