[patch] Fix ASAN crash for gdb.compile/compile.exp

Yao Qi qiyaoltc@gmail.com
Tue May 19 11:47:00 GMT 2015


Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Hi Jan,
I didn't follow the compile work in GDB very much, so I may ask
something wrong or discussed before.

> Whether the objfile really should be already freed during
> call_function_by_hand_dummy() I am not sure.

Is there any reason we release OBJFILE in the dummy frame dtor?  Why
don't we register a cleanup to release in OBJFILE in compile_object_run?
together with releasing compile_module?  'struct compile_module' has a
field objfile, which should be released together with
'struct compile_module' instead of dummy_frame.

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list