[PATCH 1/2] Whitespace terminates keywords in the linespec parser.

Keith Seitz keiths@redhat.com
Fri Mar 20 20:32:00 GMT 2015


On 03/19/2015 05:18 AM, Joel Brobecker wrote:

> I think you know this code better than anyone, but what about
> testing for the nul character as well? I'm guessing that, many times,
> a keyword at the end of the linespec is going to result in an invalid
> linespec, but it's still a keyword?

Right, but without getting too much further into this, I've elaborated 
this patch a whole lot to get better behavior.

So consider this more simplistic patch (and the test in #2) withdrawn. 
I've uncovered (and fixed) a bunch of keyword-related bugs/deficiencies.

Please see my follow-on patch, "Expand keyword lexing intelligence in 
the linespec parser."

Thank you for your review!

Keith



More information about the Gdb-patches mailing list