[PATCH 3/3 v2] Fast tracepoint for powerpc64le

Ulrich Weigand uweigand@de.ibm.com
Tue Mar 17 18:29:00 GMT 2015


Pedro Alves wrote:
> On 02/25/2015 03:27 PM, Wei-cheng Wang wrote:
> 
> > @@ -3341,6 +3357,13 @@ rs6000_frame_this_id (struct frame_info *this_frame, void **this_cache,
> >   {
> >     struct rs6000_frame_cache *info = rs6000_frame_cache (this_frame,
> >   							this_cache);
> > +
> > +  if (!info->base_p)
> > +    {
> > +      (*this_id) = frame_id_build_unavailable_stack (0);
> 
> It's best if this fills in the PC too, when possible.
> The normal path below this uses get_frame_func (this_frame).
> Can we use that here?  If that can throw unavailable,
> perhaps we could have rs6000_frame_cache save it in the
> frame cache object, inside the TRY_CATCH.

Agreed.  The patch is OK with that change.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com



More information about the Gdb-patches mailing list