[PATCH 3/5] Introduce get_value_arch

Pedro Alves palves@redhat.com
Fri Jul 24 11:27:00 GMT 2015


On 07/16/2015 07:51 PM, Simon Marchi wrote:
> Similar to get_type_arch, used to get the gdbarch associated to a
> struct value.
> 
> gdb/ChangeLog:
> 
> 	* value.c (get_value_arch): New function.
> 	* value.h (get_value_arch): New declaration.

LGTM, with:

> ---
>  gdb/value.c | 6 ++++++
>  gdb/value.h | 4 ++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/gdb/value.c b/gdb/value.c
> index 6314036..af354de 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -340,6 +340,12 @@ struct value
>    VEC(range_s) *optimized_out;
>  };
>  

Missing "/* See foo.h.  */ breadcrumb.

> +struct gdbarch *
> +get_value_arch (const struct value *value)
> +{
> +  return get_type_arch (value_type (value));
> +}
> +

Thanks,
-- 
Pedro Alves



More information about the Gdb-patches mailing list