[PATCH 1/8] Disallow using --attach and --wrapper together.

[Pedro Alves]

On 07/24/2015 09:44 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> Really not sure about this.  It's reasonable to do e.g.,
>> alias gs="gdbserver --wrapper=/whatever/wrapper --"
>> (or the equivalent wrapper shell script that execs gdbserver)
>> and then always start that instead of gdbserver:
>>
>> sometimes:
>>
>>  $ gs :9999 PROGRAM
>>
>> othertimes:
>>
>>  $ gs --attach :9999 $pid
>>
>> but after the patch, the latter errors out.
> 
> IMO, it makes sense to error out in the latter case, because --wrapper
> is useless if GDBserver attaches to a process.

The point was that before you could just forget about --wrapper,
set it once for your target/environment, having it hidden in the
script|alias-that-wraps-gdbserver.  I see it the same as putting
this in ~/.gdbinit:

 set exec-wrapper /whatever/wrapper

and then doing "$ gdb -p PID", and having GDB complain
about "set exec-wrapper" and "-p" being incompatible.

> 
>>
>> Plus, one can combine --attach and --multi, which means
>> that the wrapper would still apply to processes spawned
>> after connecting.
> 
> I agree on this case.  I withdraw this patch.
> 


Thanks,
Pedro Alves