[PATCH] Add proper handling for non-local references in nested functions
Pierre-Marie de Rodat
derodat@adacore.com
Wed Jul 22 15:14:00 GMT 2015
On 07/22/2015 04:26 PM, Doug Evans wrote:
> One thought that comes to mind when reading the patch is that
> you introduce the term "static link", and it doesn't mean what
> the casual reader will think it means.
>
> E.g.,
>
> + This method is designed to work with static links (nested
> functions
> + handling). Static links are function properties whose
> evaluation return
> + the frame base address for the enclosing frame.
>
> I think we need something less ambiguous / more clear.
Having dived in nested functions, âstatic linkâ is currently wired in my
mind to nested functions. ;-) What do you think it can be confused with?
Statically linked libraries?
One advantage of âstatic linkâ is that itâs the term which the DWARF
specification uses. GCC says âstatic chainâ instead and Iâve read
somewhere âactivation recordâ, although it actually means: the record
pointed to by the static chain.
I liked the one I used because of the DWARF specification vocabulary,
but Iâm open to changing it if itâs confusing.
Thanks in advance for the review!
--
Pierre-Marie de Rodat
More information about the Gdb-patches
mailing list