[PATCH v9 09/10] Validate symbol file using build-id

Pedro Alves palves@redhat.com
Mon Jul 13 10:34:00 GMT 2015


On 07/12/2015 08:54 PM, Eli Zaretskii wrote:
>> Date: Sun, 12 Jul 2015 21:29:11 +0200
>> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>> Cc: Doug Evans <dje@google.com>, gdb-patches <gdb-patches@sourceware.org>,
>>         Aleksandar Ristovski <ARistovski@qnx.com>,
>>         Eli Zaretskii <eliz@gnu.org>
>>
>>>> "build-id-force" sound odd to me.  The latter sounds OK,
>>>> as would "set build-id-validation on/off/...".
>>>
>>> OK, I will change it to "set build-id-validation on/off/...".
>>
>> It required some language changes as it reversed its on<->off meaning,
>> therefore Ccing Eli.
> 
> It's OK, although I wonder whether solib-validate-build-id is perhaps
> a better name.

As the plan is for the feature to apply to the main executable too,
it's better that "solib" isn't part of the setting name.  I agree
that "validate-build-id" sounds better than "build-id-validation".

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list