[commit] [patch] Print current thread after loading a core file [Re: [patch] Sort threads for thread apply all (bt)]

Jan Kratochvil jan.kratochvil@redhat.com
Thu Jan 22 18:36:00 GMT 2015


On Thu, 22 Jan 2015 01:36:42 +0100, Doug Evans wrote:
> Jan Kratochvil writes:
>  > +  /* Current thread should be NUM 1 but the user does not know that.  */
>  > +  if (thread_count () >= 2)
> 
> Can you add a comment explaining why the test is >= 2 here?
> E.g., something like
> 
>   /* Current thread should be NUM 1 but the user does not know that.
>      If a program is single threaded gdb in general does not mention
>      anything about threads.  That is why the test is >= 2.  */

Done.


> LGTM with one nit.

Checked in.


Thanks,
Jan
-------------- next part --------------
An embedded message was scrubbed...
From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH] Print current thread after loading a core file
Date: Thu, 22 Jan 2015 19:24:44 +0100
Size: 4244
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20150122/bbcd7500/attachment.eml>


More information about the Gdb-patches mailing list