[pushed] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c (Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id)

Pedro Alves palves@redhat.com
Fri Feb 27 14:47:00 GMT 2015


On 02/27/2015 02:43 PM, Eli Zaretskii wrote:
>> Date: Fri, 27 Feb 2015 13:59:05 +0000
>> From: Pedro Alves <palves@redhat.com>
>> CC: gdb-patches@sourceware.org
>>
>>>> +     Windows pipe, thus not a tty and its outputs ends up fully
>>>> +     buffered.  */
>>>> +#ifndef __MINGW32__
>>>> +  if (!isatty (fileno (stdin)))
>>>> +#endif
>>>
>>> Include unistd.h for isatty?
>>>
>>
>> ... with these fixed.
>>
>> Do you want to comment on the rest of the series, or shall I push it?
> 
> If that's isatty from the MS runtime, it will return non-zero for
> every character device, including the null device.  Is that what we
> want here?

No, and so we skip the isatty check on Windows.  Note the #ifndef.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list