[patchv2] compile: Fix GNU-IFUNC funcs called from injected code

Pedro Alves palves@redhat.com
Thu Feb 26 15:49:00 GMT 2015


On 02/24/2015 08:02 PM, Jan Kratochvil wrote:
> 
> gdb/ChangeLog
> 2015-02-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* compile/compile-c-symbols.c (convert_one_symbol, convert_symbol_bmsym)
> 	(gcc_symbol_address): Call gnu_ifunc_resolve_addr.

Looks good to me too.  OK.

I think we could probably avoid the extra infcall done
within gnu_ifunc_resolve_addr if we're going to be running
the generated code anyway, but it's not worth the effort
at this point.

> +if { [prepare_for_testing ${testfile}.exp "$testfile-debug" $srcfile] } {
> +    return -1
> +}
> +
> +if ![runto_main] {
> +    return -1
> +}
> +

Could you move these inside the prefix too, so that if they
fail for some reason, we get distinct test messages from
the nodebug case?

> +with_test_prefix "debug" {

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list