[PATCH v3 0/9] Locations API

Doug Evans xdje42@gmail.com
Mon Feb 23 04:17:00 GMT 2015


Keith Seitz <keiths@redhat.com> writes:
> This is the next revision of the locations/explicit locations mega-API
> change on which I've been working. The most important change in this
> revision is the removal of some previous ugliness introduced by the
> patch set to deal with advancing the input pointer for the CLI.
>
> In this version, all of this has been removed (even from decode_line*).
> This is now done (easily) by adding a new lexing function to find the
> end of the linespec.
>
> Thus, string_to_event_location can now treat all location types the same
> and advance the input pointer past the first terminated location string.
>
> General API usage now looks like:
>
> void
> my_command (char *arg, int from_tty)
> {
>   struct event_location *location;
>   struct cleanup *cleanup;
>
>   location = string_to_event_location (&arg, current_language);
>   cleanup = make_cleanup_delete_event_location (location);
>   if (*arg)
>     error ("junk at end of command");
>   /* do whatever with location, e.g., create_breakpoint (location, ...);  */
>   do_cleanups (cleanup);
> }
>
> One note on this series... explicit-ui-cli will introduce a failing
> test because of gdb/17960 (internal-error when completing "source.c:func").
> This is trivially fixable after that patch has been committed.
>
> I figure there's no harm in delaying further review. There's still quite
> a way to go.
>
>
> ---
>
> Keith Seitz (9):
>       Explicit locations: rename "address string"/"addr_string" to "location"
>       Explicit locations: introduce new struct event_location-based API
>       Explicit locations: use new location API
>       Explicit locations: introduce address locations
>       Explicit locations: introduce probe locations
>       Explicit locations: introduce explicit locations
>       Explicit locations: add UI features for CLI
>       Explicit locations: MI support for explicit locations
>       Explicit locations: documentation updates

Hi.

I've read through the patchset and nothing stands out as needing
major discussion, it's all very straightforward now. Cool.
[I didn't dig into everything with a fine toothed comb,
but I did read it all.]

I've written down a few nits which I'll hopefully have time
this week to put into email. I first want to apply
all the patches and see how they look as a whole.

Thanks for sticking with it, this version is nice!



More information about the Gdb-patches mailing list