Build failure with probe patch

Steve Ellcey sellcey@imgtec.com
Thu Feb 19 21:59:00 GMT 2015


On Thu, 2015-02-19 at 16:52 -0500, Sergio Durigan Junior wrote:

> > 2015-02-19  Steve Ellcey  <sellcey@imgtec.com>
> >
> > 	* dtrace-probe.c (dtrace_process_dof_probe): Initialize arg.expr.
> > 	(dtrace_get_probes) Change dof type.
> 
> I prefer "Change type of variable 'dof'".

Ok.

> > -	  dtrace_process_dof (sect, objfile, probesp, dof);
> > +	  dtrace_process_dof (sect, objfile, probesp, (struct dtrace_dof_hdr *) dof);
> 
> This line is too long.  Break it after "probesp,".

OK, I will break that line up (should have seen that myself).

Steve Ellcey
sellcey@imgtec




More information about the Gdb-patches mailing list