[PATCH] GCC5/DWARFv5 Handle DW_TAG_atomic_type for C11 _Atomic type qualifier.

[Mark Wielaard]

On Mon, 2015-02-09 at 11:56 +0400, Joel Brobecker wrote:
> > > include/ChangeLog
> > > 
> > > 	* dwarf2.def: Add DW_TAG_atomic_type.
> 
> The part in include is controlled by GCC. As soon as approved there,
> it is OK to propagate the change to binutils-gdb.git as well (just
> shooting us an email, as if applying an "obvious" patch).
> 
> Note that I went to the DWARF website, and verified that this new
> tag has been accepted with 0x47 as its value (as proposed here).

Yes, it has already been in GCC since December.

> Looks good to me, with a couple of slight nits (our faults, I'm afraid,
> but fortunately trivially fixed).
> > +++ b/gdb/testsuite/gdb.dwarf2/atomic-type.exp
> > @@ -0,0 +1,90 @@
> > +# Copyright 2014 Free Software Foundation, Inc.
> 
> Need to add 2015 to the list (that is: "2014-2015").

Done.

> > +set asm_file [standard_output_file $srcfile2]
> > +#set ptr_size [get_sizeof "void *" 96]
> 
> Delete this commented out statement.

Removed. Was a copy/paste error.

> > +/* This testcase is part of GDB, the GNU debugger.
> > +
> > +   Copyright 2004-2014 Free Software Foundation, Inc.
> 
> s/2014/2015/.

Changed.

> > +int
> > +main()
> 
> While at it, would you mind reformatting this as:
> 
> main (void)

Done.

Thanks, pushed as attached,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-GCC5-DWARFv5-Handle-DW_TAG_atomic_type-for-C11-_Atom.patch
Type: text/x-patch
Size: 13561 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20150209/56bcf7f2/attachment.bin>