[PATCH][RX] Add instraction testcase

Mike Frysinger vapier@gentoo.org
Thu Dec 24 07:41:00 GMT 2015


On 22 Dec 2015 02:34, Yoshinori Sato wrote:
> --- /dev/null
> +++ b/sim/testsuite/sim/rx/ChangeLog
> +Local Variables:
> +mode: change-log
> +left-margin: 8
> +fill-column: 74
> +version-control: never
> +change-log-default-name: "ChangeLog"
> +End:

we don't include these macros in ChangeLog files

> +; Output "pass\n"
> +	.macro pass
> +	mov.l	#0, r1		; fd == stdout
> +	mov.l	#pass_str, r2	; buf == "pass\n"
> +	mov.l	#5, r3		; len == 5
> +	sub	r4,r4
> +	bra	_write_and_exit

your pass helper prins "pass" and exits, which is good.  but a lot of
your tests do:
> +	pass
> +	exit	0

seems like you should trim the exit from all of them ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20151224/016c5159/attachment.sig>


More information about the Gdb-patches mailing list