[PATCH, ping1] Add missing expect for running a program with CLI jump

Joel Brobecker brobecker@adacore.com
Fri Dec 18 18:23:00 GMT 2015


> > 2015-10-15  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> > 
> >         * lib/mi-support.exp (mi_run_cmd_full): Add an expect for the CLI
> > jump
> >         case.

I think the patch is good, but your mailer did some line folding.
Can you resend?

Thanks!

> > 
> > 
> > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> > support.exp
> > index 0d17ecb..cc055f6 100644
> > --- a/gdb/testsuite/lib/mi-support.exp
> > +++ b/gdb/testsuite/lib/mi-support.exp
> > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args} {
> >  	# to better handle RUN.
> >  	send_gdb  "jump *$start\n"
> >  	warning "Using CLI jump command, expect run-to-main FAIL"
> > +	gdb_expect {
> > +	    -re "${run_match}&\"jump
> > \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> > f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> > id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > +	}
> >  	return 0
> >      }
> > 
> > 
> > With this patch applied, testsuite results become much more stable.
> > 
> > Is this ok for the master branch?
> > 
> > Best regards,
> > 
> > Thomas
> > 
> 

-- 
Joel



More information about the Gdb-patches mailing list