[PATCH v12 08/32] Permit multiple sysroot directories

Eli Zaretskii eliz@gnu.org
Sat Aug 22 07:31:00 GMT 2015


> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Date: Fri, 21 Aug 2015 23:21:11 +0200
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -35,6 +35,9 @@ show debug bfd-cache
>    The "/m" option is now considered deprecated: its "source-centric"
>    output hasn't proved useful in practice.
>  
> +* The "set sysroot" (and "show sysroot") commands now permit multiple
> +  directory paths.

A "path" is already a list, so I suggest this variant instead:

  The "set sysroot" (and "show sysroot") commands now accept PATH-style
  lists of directories.

> -Use @var{path} as the system root for the program being debugged.  Any
> +Use @var{path} as the system root (or list of system roots) for the
> +program being debugged.  Any

"or a list of system root directories" is more clear, I think.

> -If @var{path} starts with the sequence @file{target:} and the target
> +Multiple entries may be delimited by the host platform path separator in use.

Suggest a rewording:

  "Multiple sysroot directories can be specified in @var{path},
  separated by the host platform's path separator character (colon
  @samp{:} on Unix, semi-colon @samp{;} on MS-Windows, etc.)."

> +If @var{path} starts with the sequence @file{target:} (even if the host
> +platform path separator is character @file{:}) and the target
                              ^^^^^^^^^^^^^^^^^^
The "character" part is redundant, and please use @samp instead of
@file.

> -Display the current executable and shared library prefix.
> +Display the current executable and shared library prefix(es).

I think "prefix" is wrong here.  Why not simplify like this:

  Display the current value of sysroot, which is used to look for
  executable and shared libraries.

?

Thanks.



More information about the Gdb-patches mailing list