[rfc] btrace: change record instruction-history /m

Doug Evans dje@google.com
Tue Aug 18 00:42:00 GMT 2015


On Mon, Aug 17, 2015 at 12:23 AM, Metzger, Markus T
<markus.t.metzger@intel.com> wrote:
>> -----Original Message-----
>> From: Doug Evans [mailto:dje@google.com]
>> Sent: Friday, August 14, 2015 7:02 PM
>> To: Metzger, Markus T
>> Cc: Pedro Alves; gdb-patches
>> Subject: Re: [rfc] btrace: change record instruction-history /m
>
>
>> > Alternatively, we could extend Doug Evan's new algorithm
>> > https://sourceware.org/ml/gdb-patches/2015-08/msg00335.html to take a
>> vector
>> > of PCs.
>> >
>> > 2015-08-14  Markus Metzger <markus.t.metzger@intel.com>
>> >
>> > gdb/
>> >         * record-btrace.c (struct btrace_line_range): New.
>> >         (btrace_mk_line_range, btrace_line_range_add)
>> >         (btrace_line_range_is_empty, btrace_line_range_contains_range)
>> >         (btrace_find_line_range, btrace_print_lines): New.
>> >         (btrace_insn_history): Add source interleaving algorithm.
>>
>> Yeah, I'd like to avoid having multiple copies of code
>> doing basically the same thing.
>> Plus, no one is going to look in record-btrace.c for
>> "smart disassembly support".
>> disasm.c should be providing the necessary API
>> that the rest of gdb an use.
>
> OK, I'll look into it.  I have a few other things to do first.
>
> I wouldn't get too fancy, though, and simply replace the low/high
> PC pair with a vector of PCs.  We may have a small wrapper that
> generates the vector out of a low/high pair to keep the original
> API.

SGTM
(Including adding a new routine that takes a vector of whatever.)



More information about the Gdb-patches mailing list