[PATCH v6 2/9] Explicit locations: introduce new struct event_location-based API

Keith Seitz keiths@redhat.com
Mon Aug 10 18:05:00 GMT 2015


On 08/10/2015 10:33 AM, Doug Evans wrote:
> Later (not now, let's get this sucker checked in, unless of course
> you really want to), let's make event_location_to_string take a
> const struct event_location *, and make the cached copy
> "mutable in the c++ sense".

Bah. You got me on that one. This was used as part of the
pending-location hack ("append extra_string to the location") in
create_breakpoint:

      if (extra_string != NULL)
        {
          char *new = xstrprintf ("%s %s",
                                  event_location_to_string_const (location),
                                  extra_string);

          set_event_location_string (b->location, new);
          xfree (new);
        }

... which was removed in this revision, and I forgot to check if it was
being used at all anymore.

Answer: No, it is not used anymore. I could just remove it entirely.
Which is what I've done in my local copy. [Do you want me to repost this?]

Thanks!

Keith



More information about the Gdb-patches mailing list