[PATCH V4 5/9] New probe type: DTrace USDT probes.
Jose E. Marchesi
jose.marchesi@oracle.com
Mon Aug 10 14:31:00 GMT 2015
> Also, I didn't say it before, I wasn't so sure that casting a binary
> stream to a structure to read its contents was the best way to do
> things. It can of works, but makes the code a little harder to read,
> IMO, because accessing its contents requires the accessor macros.
> Perhaps it might be better to just have decoding routines that take
> the binary data and produce the corresponding struct, with the data
> properly decoded. That way, you can add DOF version checks and decode
> the data differently, without the rest of the code having to worry
> about which version of the type they should be using. It's not obvious
> to me that this way is better than the current way, but that's how
> I would have tried it first... (just my 2 cents)
I agree. Something else really worth doing is creating a debug setting
for DTrace probes, and print useful information while decoding them.
That sounds like a good idea. Let me work on that...
More information about the Gdb-patches
mailing list