[PATCH] Fixes to Cygwin-specific signal handling
Eli Zaretskii
eliz@gnu.org
Tue Apr 14 14:38:00 GMT 2015
> Date: Tue, 14 Apr 2015 06:16:15 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> Overall, the patch looks reasonable to me. But I think there are
> at least 3 independent changes, and it would be nice to split those
> two out, for a couple of reasons:
> 1. It allows you to explain the nature of the problem, from the user's
> standpoint, that the patch is fixing (ie, what user-visible
> symptoms it fixes);
> 2. it allows us to see how each problem is fixed, and to deal with
> each issue separately.
>
> The three issues I view as independent:
> a. ignoring "invalid handle" errors;
> b. unsetting saved_context.ContextFlags
> c. the renaming of have_saved_context into signal_thread_id
> so you can compare the current thread id with the saved
> signal_thread_id.
Also, quite a few of the changes are in non-Cygwin parts, so some
explanation of the issues would be appreciated, to make sure the
changes are safe for the native builds as well.
Thanks.
More information about the Gdb-patches
mailing list