[PATCH] Skip server-kill.exp on remote target

Yao Qi yao@codesourcery.com
Tue Sep 30 13:15:00 GMT 2014

We see the following fail in the real remote testing...

(gdb) Executing on target: kill -9 29808    (timeout = 300)
spawn [open ...]^M
sh: 1: kill: No such process

Trace can not be run on this target.^M
(gdb) FAIL: gdb.server/server-kill.exp: tstatus

The test tries to kill gdbserver in this way:

set server_pid [exp_pid -i [board_info target fileid]]
remote_exec target "kill -9 $server_pid"

in native testing, we'll get the pid of spawned gdbserver, however, in
remote testing, we'll get the pid of ssh session, since we start
gdbserver on the remote target through ssh.  The pid on build doesn't
exist on target.

I thought about different ways to handle remote target, for example:

 - use command ps on remote target to gdbserver pid, but it doesn't work
   if we have multiple gdbserver instances during testing,
 - port number can be regarded as an id to differentiate different
   instances, but port number is unknown to each test case.  Likewise,
   we can't use 'pkill' due to the same reason.
 - close the gdbserver channel, but gdbserver doesn't exit on the target,

then, I have to skip this test for remote target.


2014-09-30  Yao Qi  <yao@codesourcery.com>

	* gdb.server/server-kill.exp: Skip it if the target is remote.
 gdb/testsuite/gdb.server/server-kill.exp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 5d31103..45af850 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -23,6 +23,11 @@ if {[skip_gdbserver_tests]} {
     return 0
+# We can't get the pid of gdbserver on the remote target.
+if [is_remote target] then {
+    return 0
 if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
     return -1

More information about the Gdb-patches mailing list