[PATCH] readline/search.c: Remove useless parameter '0' for rl_message()

Joel Brobecker brobecker@adacore.com
Mon Sep 22 13:53:00 GMT 2014


> >> The related warning under Darwin x86_64:
> >> 
> >>   gcc -c -DHAVE_CONFIG_H    -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
> >>   ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
> >>     rl_message ("%s", p, 0);
> >>                 ~~~~     ^
> >>   1 warning generated.
> >> 
> >> 
> >> readline/ChangeLog.gdb:
> >> 
> >> 	* search.c (_rl_nsearch_init): Remove useless parameter '0' for
> >> 	rl_message().
> >
> > Because readline is a separate project from binutils/GDB, we prefer
> > it if you would first submit the patch to the readline project first
> > (bug-readline@gnu.org, in Cc: of this email), get it accepted there.
> 
> This bug was already fixed in bash 4.3.

I see! Sorry about the noise.  For my penance, I pushed the patch in.
Do we need it for 7.8.1 as well?

-- 
Joel



More information about the Gdb-patches mailing list