[PATCH 01/13 v2] Introduce current_lwp_ptid

Doug Evans xdje42@gmail.com
Tue Oct 28 19:43:00 GMT 2014


On Tue, Oct 28, 2014 at 10:04 AM, Pedro Alves <palves@redhat.com> wrote:
> On 10/28/2014 04:44 PM, Doug Evans wrote:
>
>> Is there a particular reason current_lwp_ptid is chosen over
>> current_thread_ptid?
>
> For-specific Linux native code, it doesn't really matter that much
> to call something "thread" or "lwp" nowadays, given with NPTL, we
> assume a 1:1 model.  But this is native Linux code working at the
> lwp level.  The code around this will end up calling iterate_over_lwps.
> And then x86_linux_dr_get thinks in terms of lwps too.  Likewise a
> all the x86 Linux debug regs related code touched or added by the
> rest of the series.  Using "lwp" here is more consistent.

Ergo my followup request:

Can a comment please be added to the declaration of current_lwp_ptid
explaining this?
[I don't have a strong preference for documenting this naming choice
with this particular function, but it's as good a place as any for
me.]



More information about the Gdb-patches mailing list