[PATCH V2 6/9] Support for DTrace USDT probes in x86_64 targets.
Pedro Alves
palves@redhat.com
Fri Oct 17 12:42:00 GMT 2014
On 10/17/2014 01:40 PM, Jose E. Marchesi wrote:
>
> Hi Pedro.
>
> Thanks for your suggestions. I updated the patch addressing them.
>
Thanks, looks good. I'm left wondering about the Solaris
question though. :-)
Just a minor detail I missed first time around:
> --- a/gdb/amd64-linux-tdep.c
> +++ b/gdb/amd64-linux-tdep.c
> @@ -28,6 +28,8 @@
> #include "gdbtypes.h"
> #include "reggroups.h"
> #include "regset.h"
> +#include "parser-defs.h"
> +#include "user-regs.h"
Please also mention these include in the CL, like:
* amd64-linux-tdep.c: Include "parser-defs.h" and "user-regs.h".
(amd64_dtrace_parse_probe_argument): New function.
...
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list