[PATCH V2 7/9] Simple testsuite for DTrace USDT probes.

Pedro Alves palves@redhat.com
Fri Oct 17 12:18:00 GMT 2014


Hi Jose,

On 10/17/2014 01:02 PM, Jose E. Marchesi wrote:
> Thanks for your suggestions.  Please take a look to this new version of
> the patch.  I think it addresses all your concerns :)

Indeed it does.  Thanks much.

One tiny nit:

> +    if {[dtrace_build_usdt_test_program] == -1} {
> +	untested ${testfile}.exp
> +        return -1
> +    }

Something odd with indentation there.

"untested ${testfile}.exp" is an anti-idiom in lots of tests :-)

See https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#A.22untested.22_calls .

Write instead:

   untested "could not compile test program"

Otherwise looks good.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list