RFC: gdbserver crash on win XP during watchpoint removal

Joel Brobecker brobecker@adacore.com
Wed Oct 15 14:35:00 GMT 2014


> > It looks like just removing the statement that sets dr_control_mirror
> > from the thread's DR7 is sufficient to allow hardware watchpoints
> > to work again.
> 
> Yes, that sounds good enough for 7.8.1.  This is OK.

Thanks, Pedro. I created PR server/17487 for this, and pushed
the patch on gdb-7.8-branch using that PR.

> > I admit I could have spent a little more time trying to understand
> > the bigger picture, but I'm a bit under time pressure, so I'm hoping
> > this is enough. Otherwise, I'll look at a better fix.
> 
> Hmm, I've wanted to do this for a while.  So...  Below's is what I
> think is the better fix.

Thanks! I tested your patch on x86-windows using AdaCore's testsuite,
and it also fixes the problem, with no regression. Do you want to push
it? I left the PR open pending your patch going in...

-- 
Joel



More information about the Gdb-patches mailing list