[PATCH] Don't check target_info exists noargs in commands.exp

Pedro Alves palves@redhat.com
Wed Oct 15 14:05:00 GMT 2014


Hi Yao.

Makes sense to me.   Though it looks to me like to be
thorough we should remove all the "set args ..." lines too, like:

>      gdb_test_no_output "set args 5" "set args in progvar_simple_while_test"
                           ^^^^^^^^^^
>      if { ![runto factorial] } then { gdb_suppress_tests }
>      # Don't depend upon argument passing, since most simulators don't

and several more as visible in the patch.

Thanks,
Pedro Alves

> @@ -102,11 +92,6 @@ proc progvar_simple_while_test {} {
>  proc progvar_complex_if_while_test {} {
>      global gdb_prompt
>  
> -    if [target_info exists noargs] { 
> -        verbose "Skipping progvar_simple_if_while_test because of noargs."
> -        return
> -    }
> -
>      gdb_test_no_output "set args 4" \
>  	"set args in progvar_complex_if_while_test"
>      if { ![runto factorial] } then { gdb_suppress_tests }
> @@ -121,10 +106,6 @@ proc progvar_complex_if_while_test {} {
>  }
>  
>  proc if_while_breakpoint_command_test {} {
> -    if [target_info exists noargs] { 
> -        verbose "Skipping if_while_breakpoint_command_test because of noargs."
> -        return
> -    }
>  
>      gdb_test_no_output "set args 5" \
>  	"set args in if_while_breakpoint_command_test"
> @@ -162,10 +143,6 @@ proc if_while_breakpoint_command_test {} {
>  # subsection "Breakpoint command lists".
>  
>  proc infrun_breakpoint_command_test {} {
> -    if [target_info exists noargs] { 
> -        verbose "Skipping infrun_breakpoint_command_test because of noargs."
> -        return
> -    }
>  
>      gdb_test_no_output "set args 6" \
>  	"set args in infrun_breakpoint_command_test"
> @@ -197,10 +174,6 @@ proc infrun_breakpoint_command_test {} {
>  }
>  
>  proc breakpoint_command_test {} {
> -    if [target_info exists noargs] { 
> -        verbose "Skipping breakpoint_command_test because of noargs."
> -        return
> -    }
>  
>      gdb_test_no_output "set args 6" "set args in breakpoint_command_test"
>      if { ![runto factorial] } then { gdb_suppress_tests; }
> @@ -268,14 +241,8 @@ proc user_defined_command_test {} {
>  }
>  
>  proc watchpoint_command_test {} {
> -    global noargs
>      global gdb_prompt
>  
> -    if [target_info exists noargs] { 
> -        verbose "Skipping watchpoint_command_test because of noargs."
> -        return
> -    }
> -
>      # Disable hardware watchpoints if necessary.
>      if [target_info exists gdb,no_hardware_watchpoints] {
>  	gdb_test_no_output "set can-use-hw-watchpoints 0" ""
> @@ -348,11 +315,6 @@ proc watchpoint_command_test {} {
>  proc test_command_prompt_position {} {
>      global gdb_prompt
>  
> -    if [target_info exists noargs] { 
> -        verbose "Skipping test_command_prompt_position because of noargs."
> -        return
> -    }
> -
>      if { ![runto factorial] } then { gdb_suppress_tests; }
>      # Don't depend upon argument passing, since most simulators don't
>      # currently support it.  Bash value variable to be what we want.
> @@ -446,11 +408,6 @@ proc deprecated_command_test {} {
>  
>  proc bp_deleted_in_command_test {} {
>      global gdb_prompt
> -    
> -    if [target_info exists noargs] { 
> -        verbose "Skipping bp_deleted_in_command_test because of noargs."
> -        return
> -    }
>  
>      gdb_test_no_output "set args 1" \
>  	"set args in bp_deleted_in_command_test"
> @@ -498,11 +455,6 @@ proc bp_deleted_in_command_test {} {
>  
>  proc temporary_breakpoint_commands {} {
>      global gdb_prompt
> -    
> -    if [target_info exists noargs] { 
> -        verbose "Skipping temporary_breakpoint_commands because of noargs."
> -        return
> -    }
>  
>      gdb_test_no_output "set args 1" \
>  	"set args in temporary_breakpoint_commands"
> 



More information about the Gdb-patches mailing list