[commit] [patchv2 1/2] save breakpoints does not save disabled breakpoints correctly

[Jan Kratochvil]

On Fri, 10 Oct 2014 07:55:50 +0200, Yao Qi wrote:
> These two patches look right to me.

Therefore checked them in.


On Fri, 10 Oct 2014 14:31:21 +0200, Pedro Alves wrote:
> In places were we want to avoid that, and we want to write a pattern
> that spawns multiple lines, we build the regex with join.  E.g.,
> gdb.btrace/instruction_history.exp:
> 
> # test that we see the expected instructions
> gdb_test "record instruction-history 3,7" [join [list \
>   "3\t   0x\[0-9a-f\]+ <loop\\+\[0-9\]+>:\tje     0x\[0-9a-f\]+ <loop\\+\[0-9\]+>" \
>   "4\t   0x\[0-9a-f\]+ <loop\\+\[0-9\]+>:\tdec    %eax" \
>   "5\t   0x\[0-9a-f\]+ <loop\\+\[0-9\]+>:\tjmp    0x\[0-9a-f\]+ <loop\\+\[0-9\]+>" \
>   "6\t   0x\[0-9a-f\]+ <loop\\+\[0-9\]+>:\tcmp    \\\$0x0,%eax" \
>   "7\t   0x\[0-9a-f\]+ <loop\\+\[0-9\]+>:\tje     0x\[0-9a-f\]+ <loop\\+\[0-9\]+>\r" \
>   ] "\r\n"]

This looks more safe to me but the other was has been approved.


Thanks,
Jan
-------------- next part --------------
An embedded message was scrubbed...
From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH 1/2] Use gdb_test_sequence in gdb.base/save-bp.exp.
Date: Sun, 12 Oct 2014 21:47:13 +0200
Size: 4057
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20141012/765e8307/attachment.eml>
-------------- next part --------------
An embedded message was scrubbed...
From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH 2/2] Fix "save breakpoints" for "disable $bpnum" command.
Date: Sun, 12 Oct 2014 21:52:39 +0200
Size: 4126
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20141012/765e8307/attachment-0001.eml>