[PATCH V2 3/9] New commands `enable probe' and `disable probe'.

Eli Zaretskii eliz@gnu.org
Fri Oct 10 18:15:00 GMT 2014


> From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
> Date: Fri, 10 Oct 2014 19:22:46 +0200
> 
> +Some probe points can be enabled and/or disabled.  The effects
> +associated to enabling or disabling a probe depend on the type of

Just "the effect of enabling or disabling a probe" is enough, and much
more clear.

> +probe being handled. @code{SystemTap} probes do not support these
                      ^^
Two spaces between sentences.

Also, I think we agreed to say SystemTap probes cannot be disabled.

> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}
> +If given, @var{provider} is a regular expression used to match against
> +provider names when selecting which probes to enable.  If omitted,
> +probes by all probes from all providers are enabled.

"Probes by all probes"?  Something is wrong here.

Thanks.



More information about the Gdb-patches mailing list