[PATCH] MIPS: Ignore invalid regs during info registers all
James Hogan
james.hogan@imgtec.com
Mon Oct 6 10:02:00 GMT 2014
Hi Maciej,
On 03/10/14 17:32, Maciej W. Rozycki wrote:
> On Tue, 30 Sep 2014, Pedro Alves wrote:
>
>>>>> The "info registers all" command causes mips_print_registers_info () to be
>>>>> called for all register numbers, including invalid ones such as unused DSP
>>>>> register numbers. This triggers an error () call which prevents further
>>>>> register values being printed. Just silently return without printing
>>>>> anything or erroring, so that all valid registers can be printed.
>>>>
>>>> What happens when the user does "info registers that-unused-register" ?
>>>
>>> I don't think that's possible, because the check is:
>>> if (*(gdbarch_register_name (gdbarch, regnum)) == '\0')
>>>
>>> So any such register already has no name by which to refer to it.
>>
>> Indeed. :-) I'll leave it to Maciej to approve.
>
> I didn't know `info registers' (and `info all-registers' presumably as
> well) supported further arguments; I'll experiment with the patch a bit
> and see what comes out.
>
> James, did you push your change through regression testing? If so, then
> how? Please always state precisely how changes you submit have been
> validated.
No I didn't. I'll get myself set up for running the test suite.
Cheers
James
More information about the Gdb-patches
mailing list