[PATCH 07/12] btrace: extend struct btrace_insn

[Pedro Alves]

On 07/14/2014 02:56 PM, Markus Metzger wrote:
> +static enum btrace_insn_class
> +ftrace_classify_insn (struct gdbarch *gdbarch, CORE_ADDR pc)

Missing intro comment.

> +{
> +  volatile struct gdb_exception error;
> +  enum btrace_insn_class iclass;
> +
> +  iclass = BTRACE_INSN_OTHER;
> +  TRY_CATCH (error, RETURN_MASK_ALL)

This swallows ctrl-c.  I think it should be RETURN_MASK_ERROR.
Likewise other TRY_CATCH uses.

> +    {

Thanks,
Pedro Alves