[PATCH 2/3] make "permanent breakpoints" per location and disableable
Yao Qi
yao@codesourcery.com
Wed Nov 5 06:37:00 GMT 2014
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
I go through this patch, and don't see anything wrong except this below,
> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
> index 118a37f..c383cd4 100644
> --- a/gdb/breakpoint.h
> +++ b/gdb/breakpoint.h
> @@ -193,12 +193,6 @@ enum enable_state
> automatically enabled and reset when the
> call "lands" (either completes, or stops
> at another eventpoint). */
> - bp_permanent /* There is a breakpoint instruction
> - hard-wired into the target's code. Don't
> - try to write another breakpoint
> - instruction on top of it, or restore its
> - value. Step over it using the
> - architecture's SKIP_INSN macro. */
> };
This causes a compilation error in guile/scm-breakpoint.c where
bp_permanent is in use.
../../../git/gdb/guile/scm-breakpoint.c: In function ‘bpscm_enable_state_to_string’:
../../../git/gdb/guile/scm-breakpoint.c:154:10: error: ‘bp_permanent’ undeclared (first use in this function)
case bp_permanent: return "permanent";
static const char *
bpscm_enable_state_to_string (enum enable_state enable_state)
{
switch (enable_state)
{
case bp_disabled: return "disabled";
case bp_enabled: return "enabled";
case bp_call_disabled: return "call_disabled";
case bp_permanent: return "permanent";
^^^^^^^^^^^^
default: return "unknown";
}
}
--
Yao (齐尧)
More information about the Gdb-patches
mailing list