[PATCH] Fix prologue analysis for ldr.w and ldrd instruction

Luis Machado lgustavo@codesourcery.com
Wed May 7 15:41:00 GMT 2014


Joel,

On 05/07/2014 12:33 PM, tmirza wrote:
> On 05/07/2014 06:25 PM, Joel Brobecker wrote:
>>>> 2014-05-06  Taimoor Mirza  <tmirza@codesourcery.com>
>>>>
>>>>          gdb/
>>>>          * arm-tdep.c (thumb_analyze_prologue): Fix offset
>>>> calculation for
>>>>          ldr.w and ldrd instructions.
>> [...]
>>> This looks good to me, assuming the testsuite was run with no
>>> regressions.
> Thanks for the review Will. Yes I ran testsuites.
>> Thanks, Will, for reviewing the patch. I concur on both counts:
>> patch is approved, but can you please also confirm how the patch
>> was tested?
> I ran testsuites before and after applying my patch and did not find any
> regression.
>>
>> Thank you,

Just for the sake of completeness, the patch was tested against real 
boards and a simulator.

Luis



More information about the Gdb-patches mailing list