[PUSHED 0/2] Make local-remote-host.exp force pseudo-tty allocation; add local-remote-host-notty.exp

[Pedro Alves]

On 03/26/2014 05:47 AM, Yao Qi wrote:
> The completion feature and other features on readline depend on the
> readline library.  However, readline library is not always used, for
> example, running testsuite like
> 
>   make check RUNTESTFLAGS="--host_board=local-remote-host"
> 
> the input stream is not a tty, and GDB doesn't use readline library
> as a result.

It's kind of lame that the board does that though.  There are testing
setups that can't do better, so it's good to be able to good emulate
them, but unix-like setups can just use "ssh -t" when spawning
interactive programs.

I pushed the series below.  With:

 make check RUNTESTFLAGS="--host_board=local-remote-host" \
      TESTS="gdb.ada/complete.exp \
      gdb.base/filesym.exp \
      gdb.base/macscp.exp \
      gdb.base/readline-ask.exp \
      gdb.base/readline.exp \
      gdb.python/py-cmd.exp \
      gdb.trace/tfile.exp"

(the tests you touched) we still get:

 $ cat testsuite/gdb.sum| grep "^FAIL"
 FAIL: gdb.trace/tfile.exp: target tfile tfile-basic.tf
 FAIL: gdb.trace/tfile.exp: info tracepoints on trace file
 FAIL: gdb.trace/tfile.exp: tfind 0 on trace file
 FAIL: gdb.trace/tfile.exp: print nonconstglob on trace file
 FAIL: gdb.trace/tfile.exp: tstatus on trace file
 FAIL: gdb.trace/tfile.exp: target tfile tfile-error.tf
 FAIL: gdb.trace/tfile.exp: tstatus on error trace file
 FAIL: gdb.trace/tfile.exp: interpreter-exec mi "-target-select tfile tfile-basic.tf"
 FAIL: gdb.trace/tfile.exp: -trace-status
 FAIL: gdb.trace/tfile.exp: complete-command 'target tfile'
 FAIL: gdb.base/readline-ask.exp: ask message (timeout)
 FAIL: gdb.ada/complete.exp: compilation foo.adb

though that looks like forward progress anyhow.  The tfile.exp issue
looks like completely unrelated.

Pedro Alves (2):
  Rename testsuite/boards/local-remote-host.exp ->
    testsuite/boards/local-remote-host-notty.exp
  New testsuite/boards/local-remote-host.exp board, now with editing
    on

 gdb/testsuite/ChangeLog                          |  9 +++++
 gdb/testsuite/boards/local-remote-host-notty.exp | 46 ++++++++++++++++++++++++
 gdb/testsuite/boards/local-remote-host.exp       | 38 +++++++-------------
 3 files changed, 67 insertions(+), 26 deletions(-)
 create mode 100644 gdb/testsuite/boards/local-remote-host-notty.exp

-- 
1.7.11.7