[patch] Mark some tests as XFAIL/UNSUPPORTED hidden due to GCC's omission of typedefs in inheritance.

Pedro Alves palves@redhat.com
Thu May 1 11:07:00 GMT 2014


re-reading this, I actually have comments now.  :-)

On 04/25/2014 03:48 AM, David Blaikie wrote:
> -	"Cannot reference non-static field \"i\""
> -    gdb_test "print B<int>::A<int>::i" "Cannot reference non-static field \"i\""
> +    if {[test_compiler_info {gcc-*-*}]} {
> +        unsupported "gdb/16841"

Making this "unsupported" and skipping the actual tests means that we'll
just end up never ever again testing this against gcc, because I guarantee
you that if gcc changes, nobody will ever remember to adjust this test.
I don't think we should do that.

> Due to GCC's PR14819 these tests weren't actually testing this case -

GCC's PR14819 doesn't seem to be related.  Did you mean some other bug?
Or did you mean _GDB_'s PR14819?

> GCC produces the same debug info regardless of whether there's a
> typedef used in the base specifier.

> +    } else {
> +        setup_kfail gdb/16841 *-*-*
> +        gdb_test "print D::B<int>::i" "Cannot reference non-static field \"i\""
> +        gdb_test "print D::Bint::i" "Cannot reference non-static field \"i\""
> +        gdb_test "print B<int>::i" "Cannot reference non-static field \"i\""
> +        setup_kfail gdb/16841 *-*-*
> +        gdb_test "print D::B<int>::A<int>::i" \
> +

-- 
Pedro Alves



More information about the Gdb-patches mailing list