[RFA] Fix c++/16253 (tag/variable name collision)

[Keith Seitz]

On 03/24/2014 07:15 AM, Joel Brobecker wrote:
> This may not be directly related to your patch. I seem to have seen
> some unexplainable behavior in GDB occasionally in the recent past
> making me wonder whether there might be something fishy in the symbol
> lookup for Ada.

It is my patch that is causing the problems.

In this case, add_nonlocal_symbols is calling the qf 
map_matching_symbols method which is calling match_partial_symbol. Since 
this method now does strict matches against domain, an explicit check 
for STRUCT_DOMAIN matches must be added.

Give this amendment a shot and see how it goes. I suspect there are 
probably one or two more places where this occurs. [The easiest thing to 
do is audit any function which uses "VAR_DOMAIN".]

Keith

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16253-amended-1.patch
Type: text/x-patch
Size: 1444 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20140325/d999223d/attachment.bin>