[PATCH][PR/backtrace 16721] Fix erroneous backtrace on AVR
Pierre Langlois
pierre.langlois@embecosm.com
Fri Mar 21 13:23:00 GMT 2014
Hi Joel,
Sorry for the late reply.
> Now that Tristan approved the patch, do you have an FSF copyright
> assignment on file? This patch is small that we can push it in without;
> but if you are planning on sending more, you'll need one. Just let me
> know and I will get you a message to get you started (it takes a while
> to complete, so the sooner the better).
I am doing this work on behalf of Embecosm, we have an FSF copyright assignment
on file.
> One remark on the ChangeLog; the formatting is off a bit. It should be
> indented by one tab, and the indentation should be the same, regardless
> of whether the line starts with a '*' or not - no extra indentation
> for continuation lines. Thus:
>
> * avr-tdep.c (avr_scan_prologue): Accept push r1 instruction for small
> stack allocation.
>
> (in emails, it's not important to be using 8 spaces or 1 tab, but in
> the CL, we tend to be picky about it).
I'll make sure my email client is properly configured next time.
Thank you very much!
Pierre
More information about the Gdb-patches
mailing list