[PATCH] Don't mention "Unix" in native target name.
Pedro Alves
palves@redhat.com
Wed Mar 12 12:38:00 GMT 2014
I wonder whether anyone would miss this badly? The difference would be:
(gdb) maint print target-stack
The current target stack is:
- multi-thread (multi-threaded child process.)
- - child (Unix child process)
+ - child (Child process)
- exec (Local exec file)
- None (None)
(gdb) help target child
- Unix child process (started by the "run" command).
+ Child process (started by the "run" command).
I find it unnecessary (and really slightly a lie) on GNU/Linux.
It's also odd that e.g., the Windows port says "Unix" in reaction to
"target child" (it was already that way before Windows used
inf-child.c).
How about we just say the same mostly everywhere?
In the same vein, I'd also rename Solaris/procfs.c's "target procfs"
to "target child".
gdb/
2014-03-12 Pedro Alves <palves@redhat.com>
* inf-child.c (inf_child_open, inf_child_target): Don't mention
Unix in user visible strings.
---
gdb/inf-child.c | 6 +++---
gdb/testsuite/gdb.base/default.exp | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/inf-child.c b/gdb/inf-child.c
index ee63dd1..bfa9152 100644
--- a/gdb/inf-child.c
+++ b/gdb/inf-child.c
@@ -112,7 +112,7 @@ inf_child_prepare_to_store (struct target_ops *self,
static void
inf_child_open (char *arg, int from_tty)
{
- error (_("Use the \"run\" command to start a Unix child process."));
+ error (_("Use the \"run\" command to start a child process."));
}
static void
@@ -398,8 +398,8 @@ inf_child_target (void)
struct target_ops *t = XCNEW (struct target_ops);
t->to_shortname = "child";
- t->to_longname = "Unix child process";
- t->to_doc = "Unix child process (started by the \"run\" command).";
+ t->to_longname = "Child process";
+ t->to_doc = "Child process (started by the \"run\" command).";
t->to_open = inf_child_open;
t->to_post_attach = inf_child_post_attach;
t->to_fetch_registers = inf_child_fetch_inferior_registers;
diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
index 73c33ba..b63955e 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -747,10 +747,10 @@ gdb_test "step" "The program is not being run." "step #2"
gdb_test "symbol-file" ".*" "symbol-file"
#test target child
-gdb_test "target child" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child"
+gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child"
#test target procfs
-gdb_test "target procfs" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs"
+gdb_test "target procfs" "Use the \"run\" command to start a child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs"
#test target core
send_gdb "target core\n"
--
1.7.11.7
More information about the Gdb-patches
mailing list