[PATCH 2/3] gdb/python: raise TypeError instead of abort() on calling .value() method for label symbol object

Maxim Bublis satori@yandex-team.ru
Wed Mar 5 13:39:00 GMT 2014


> This patch looks fine to me apart from one further small aside (please
> wait for a maintainer to approve your patch, regardless). In the
> documentation you note there are other types of symbol that can
> produce this error: e.g., SYMBOL_LOC_TYPEDEF.  Can you please audit and
> include checks for all, while you are there? I noticed only the
> explicit LOC_LABEL check in the patch above.

There is already implemented similar behavior for LOC_TYPEDEF, so no additional work here should be done.
On the other hand there is no testcase for typedef symbol object .value() method call.
Maybe you could provide me a help with writing such testcase as I do not quietly understand how typedef symbol object could be retrieved.


More information about the Gdb-patches mailing list