[PATCH 0/7] Refactor shared code in {i386,amd64}-linux-nat.c

[Pedro Alves]

On 06/27/2014 11:39 AM, Pedro Alves wrote:
> The resulting #ifdefery quite reasonable, IMNSHO -- it'd be bad if there
> were lots of different combinations of symbols we'd have to #ifdef on,
> but there's really only a few #ifdef __x86_64__.  So if it's
> spaghetti, it's still dry, raw, straight and neatly lined up
> in the package.  :-)

Ah, I found one bit where there's more #ifdefery than necessary.
So the spaghetti did catch some moisture.  :-)

Gary, please compare your resulting x86_linux_read_description
with gdbserver's x86_linux_read_description.  Notice how it
has fewer #ifdef blocks.  Could you rework your version of the
function in that direction please?

Thanks,
-- 
Pedro Alves