>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes: Yao> file_name isn't used out side of this block, so we can define file_name Yao> within this block of type "char *", and patch can be shorter. The problem is that we need to set "file_names = &file_name", and you can't take the address of a "char *" and cast that to "const char **". Tom